gh-142651: use NonCallableMock._lock for thread safety of call_count#142922
Open
kumaraditya303 wants to merge 1 commit intopython:mainfrom
Open
gh-142651: use NonCallableMock._lock for thread safety of call_count#142922kumaraditya303 wants to merge 1 commit intopython:mainfrom
NonCallableMock._lock for thread safety of call_count#142922kumaraditya303 wants to merge 1 commit intopython:mainfrom
Conversation
kumaraditya303
added
skip news
needs backport to 3.13
Contributor
Author
|
No failure in 300+ iterations: 0:07:48 load avg: 3.39 [356] test_unittest.testmock.testthreadingmock passed (51.5 sec) -- running (3): test_unittest.testmock.testthreadingmock (51.8 sec), test_unittest.testmock.testthreadingmock (51.7 sec), test_unittest.testmock.testthreadingmock (51.9 sec)
0:07:48 load avg: 3.39 [357] test_unittest.testmock.testthreadingmock passed (51.7 sec) -- running (3): test_unittest.testmock.testthreadingmock (51.8 sec), test_unittest.testmock.testthreadingmock (51.7 sec), test_unittest.testmock.testthreadingmock (51.9 sec)
0:07:48 load avg: 3.39 [358] test_unittest.testmock.testthreadingmock passed (51.8 sec) -- running (1): test_unittest.testmock.testthreadingmock (51.9 sec)
0:07:48 load avg: 3.39 [359] test_unittest.testmock.testthreadingmock passed (51.7 sec)
0:07:48 load avg: 3.39 [360] test_unittest.testmock.testthreadingmock passed (51.9 sec) |
Contributor
|
Hi @kumaraditya303 , I have two questions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadingMock.call_countis not thread safe #142651Skipping news as the there is already a news entry in the original PR.